linux/ioctlent: unify them all

Dmitry V. Levin ldv at altlinux.org
Tue Mar 1 11:46:48 UTC 2011


On Tue, Mar 01, 2011 at 05:54:44AM -0500, Mike Frysinger wrote:
> On Tuesday, March 01, 2011 05:31:40 Dmitry V. Levin wrote:
> > On Mon, Feb 28, 2011 at 08:21:17PM -0500, Mike Frysinger wrote:
> > > The basic method is:
> > >  - each arch has linux/<arch>/ioctlent.h.in which defines only the
> > >    arch-specific ioctls
> > >  - linux/ioctlent.h.in which defines only the common ioctls
> > >  - at build time, these two headers are combined & sorted to produce
> > >    the linux/ioctlent.h file
> > 
> > I wonder how to update these *.h.in files after the change?
> > linux/ioctlent.sh still generates old stuff, so whether
> > ./configure --enable-maintainer-mode && make
> > would work properly?
> 
> i think we'd want to update ioctlent.sh to auto scan all arches

It would be nice, but I'm doubt that ioctlsort could be run on all arches
at once.

> > > ive deleted all the delete hunks from this patch.  to reproduce:
> > > 		git rm linux/*/ioctlent.h
> > > 	
> > > 	The ioctlent.h.in files were created by:
> > > 		grep asm ioctlent.h > ioctlent.h.in
> > 
> > Something went wrong with this commit:
> > $ find linux/ -size 0
> > linux/s390x/ioctlent.h.in
> > linux/sparc64/ioctlent.h.in
> > linux/hppa/ioctlent.h.in
> 
> i havent tested all the arches yet ... i wanted to get the basic idea down 
> before i verified it all
> 
> so if you're happy with this, i can start that process

There seems to be no regression with final ioctlent.h files on i386 and ppc,
it proves that the basic idea is good, so please proceed with the update.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20110301/6ff9e35e/attachment.bin>


More information about the Strace-devel mailing list