[PATCH] strace: Add block ioctl support

Jeff Mahoney jeffm at suse.com
Wed Dec 8 19:47:25 UTC 2010


 This patch adds support for blkdev_ioctl()-handled ioctls. It was initially
 submitted last year and I lost track of it until Petr Uzel reminded me
 about it this afternoon.

 This version addresses the comments offered during review in this thread:
 http://www.mail-archive.com/strace-devel@lists.sourceforge.net/msg01338.html

 I've added the copyright/license header to block.c, used xlat/xlookup,
 and provided ioctl definitions for those that may not be available on older
 systems.

Signed-off-by: Jeff Mahoney <jeffm at suse.com>
---
 Makefile.am       |    2 
 block.c           |  295 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 defs.h            |    1 
 ioctl.c           |    3 
 linux/ioctlent.sh |    3 
 5 files changed, 303 insertions(+), 1 deletion(-)

--- a/Makefile.am
+++ b/Makefile.am
@@ -15,7 +15,7 @@ INCLUDES = -I$(srcdir)/$(OS)/$(ARCH) -I$
 strace_SOURCES = strace.c syscall.c count.c util.c desc.c file.c ipc.c \
 		 io.c ioctl.c mem.c net.c process.c bjm.c quota.c \
 		 resource.c signal.c sock.c system.c term.c time.c \
-		 proc.c scsi.c stream.c
+                proc.c scsi.c stream.c block.c
 noinst_HEADERS = defs.h
 
 EXTRA_DIST = $(man_MANS) errnoent.sh signalent.sh syscallent.sh ioctlsort.c \
--- /dev/null
+++ b/block.c
@@ -0,0 +1,295 @@
+/*
+ * Copyright (c) 2009, 2010 Jeff Mahoney <jeffm at suse.com>
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote products
+ *    derived from this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ *	$Id$
+ */
+
+#include "defs.h"
+#ifdef LINUX
+#include <stdint.h>
+#include <linux/blkpg.h>
+#include <linux/fs.h>
+#include <linux/hdreg.h>
+
+/* ioctls <= 114 are present in Linux 2.4. The following ones have been
+ * added since then and headers containing them may not be available on
+ * every system. */
+
+#define BLKTRACE_BDEV_SIZE      32
+struct blk_user_trace_setup {
+	char name[BLKTRACE_BDEV_SIZE];	/* output */
+	uint16_t act_mask;		/* input */
+	uint32_t buf_size;		/* input */
+	uint32_t buf_nr;		/* input */
+	uint64_t start_lba;
+	uint64_t end_lba;
+	uint32_t pid;
+};
+
+#ifndef BLKTRACESETUP
+#define BLKTRACESETUP _IOWR(0x12,115,struct blk_user_trace_setup)
+#endif
+#ifndef BLKTRACESTART
+#define BLKTRACESTART _IO(0x12,116)
+#endif
+#ifndef BLKTRACESTART
+#define BLKTRACESTOP _IO(0x12,117)
+#endif
+#ifndef BLKTRACETEARDOWN
+#define BLKTRACETEARDOWN _IO(0x12,118)
+#endif
+#ifndef BLKDISCARD
+#define BLKDISCARD _IO(0x12,119)
+#endif
+#ifndef BLKIOMIN
+#define BLKIOMIN _IO(0x12,120)
+#endif
+#ifndef BLKIOOPT
+#define BLKIOOPT _IO(0x12,121)
+#endif
+#ifndef BLKALIGNOFF
+#define BLKALIGNOFF _IO(0x12,122)
+#endif
+#ifndef BLKPBSZGET
+#define BLKPBSZGET _IO(0x12,123)
+#endif
+#ifndef BLKDISCARDZEROES
+#define BLKDISCARDZEROES _IO(0x12,124)
+#endif
+#ifndef BLKSECDISCARD
+#define BLKSECDISCARD _IO(0x12,125)
+#endif
+
+static const struct xlat blkpg_ops[] = {
+	{ BLKPG_ADD_PARTITION,	"BLKPG_ADD_PARTITION", },
+	{ BLKPG_DEL_PARTITION,	"BLKPG_DEL_PARTITION", },
+	{ 0,			NULL },
+};
+
+static void
+print_blkpg_req(struct tcb *tcp, struct blkpg_ioctl_arg *blkpg)
+{
+	struct blkpg_partition p;
+	const char *ioctl_name;
+
+	ioctl_name = xlookup(blkpg_ops, blkpg->op);
+	if (!ioctl_name) {
+		tprintf("{%#x, /* BLKPG_??? */", blkpg->op);
+		return;
+	}
+
+	tprintf("{%s, flags=%d, datalen=%d, ",
+		ioctl_name, blkpg->flags, blkpg->datalen);
+
+	if (umove(tcp, (unsigned long)blkpg->data, &p) < 0) {
+		tprintf("%#lx", (unsigned long)blkpg->data);
+		return;
+	}
+
+	tprintf("{start=%lld, length=%lld, pno=%d, ",
+		p.start, p.length, p.pno);
+
+	tprintf("devname=\"%s\", volname=\"%s\"}",
+		p.devname, p.volname);
+}
+
+int
+block_ioctl(struct tcb *tcp, long code, long arg)
+{
+	switch (code) {
+
+	/* These pass arg as a value, not a pointer */
+	case BLKRASET:
+	case BLKFRASET:
+		if (entering(tcp))
+			tprintf(", %ld", arg);
+		break;
+
+	/* Just pass in a signed int */
+	case BLKROSET:
+	case BLKBSZSET:
+		if (entering(tcp)) {
+			int int_val;
+			if (umove(tcp, arg, &int_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %d", int_val);
+		}
+		break;
+
+	/* Just return an unsigned short */
+	case BLKSECTGET:
+		if (exiting(tcp)) {
+			unsigned short ushort_val;
+			if (umove(tcp, arg, &ushort_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %hu", ushort_val);
+		}
+		break;
+
+	/* Just return a signed int */
+	case BLKROGET:
+	case BLKBSZGET:
+	case BLKSSZGET:
+	case BLKALIGNOFF:
+		if (exiting(tcp)) {
+			int int_val;
+			if (umove(tcp, arg, &int_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %d", int_val);
+		}
+		break;
+
+	/* Just return an unsigned int */
+	case BLKPBSZGET:
+	case BLKIOMIN:
+	case BLKIOOPT:
+	case BLKDISCARDZEROES:
+		if (exiting(tcp)) {
+			unsigned int uint_val;
+			if (umove(tcp, arg, &uint_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %u", uint_val);
+		}
+		break;
+
+	/* Just return a signed long */
+	case BLKRAGET:
+	case BLKFRAGET:
+		if (exiting(tcp)) {
+			long size;
+			if (umove(tcp, arg, &size) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %ld", size);
+		}
+		break;
+
+	/* Just return an unsigned long */
+	case BLKGETSIZE:
+		if (exiting(tcp)) {
+			unsigned long ulong_val;
+			if (umove(tcp, arg, &ulong_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %lu", ulong_val);
+			}
+		break;
+
+	/* Just return a quad */
+	case BLKGETSIZE64:
+		if (exiting(tcp)) {
+			uint64_t uint64_val;
+			if (umove(tcp, arg, &uint64_val) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", %llu",
+					(unsigned long long)uint64_val);
+		}
+		break;
+
+	/* More complex types */
+	case BLKDISCARD:
+	case BLKSECDISCARD:
+		if (entering(tcp)) {
+			uint64_t range[2];
+			if (umove(tcp, arg, range) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", {%llx, %llx}",
+					(unsigned long long)range[0],
+					(unsigned long long)range[1]);
+		}
+		break;
+
+	case HDIO_GETGEO:
+		if (exiting(tcp)) {
+			struct hd_geometry geo;
+			if (umove(tcp, arg, &geo) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", {heads=%hhu, sectors=%hhu, "
+					"cylinders=%hu, start=%lu}",
+					geo.heads, geo.sectors,
+					geo.cylinders, geo.start);
+		}
+		break;
+	case BLKPG:
+		if (entering(tcp)) {
+			struct blkpg_ioctl_arg blkpg;
+			if (umove(tcp, arg, &blkpg) < 0)
+				tprintf(", %#lx", arg);
+			else {
+				tprintf(", ");
+				print_blkpg_req(tcp, &blkpg);
+			}
+		}
+		if (exiting(tcp)) {
+			tprintf("}");
+		}
+		break;
+	case BLKTRACESETUP:
+		if (entering(tcp)) {
+			struct blk_user_trace_setup buts;
+			if (umove(tcp, arg, &buts) < 0)
+				tprintf(", %#lx", arg);
+			else {
+				tprintf(", {act_mask=%hu, buf_size=%u, ",
+					buts.act_mask, buts.buf_size);
+				tprintf("buf_nr=%u, start_lba=%llu, ",
+					buts.buf_nr,
+					(unsigned long long)buts.start_lba);
+				tprintf("end_lba=%llu, pid=%u}",
+					(unsigned long long)buts.end_lba,
+					buts.pid);
+			}
+		}
+		if (exiting(tcp)) {
+			struct blk_user_trace_setup buts;
+			if (umove(tcp, arg, &buts) < 0)
+				tprintf(", %#lx", arg);
+			else
+				tprintf(", {name=\"%s\"}", buts.name);
+		}
+		break;
+	/* No arguments or unhandled */
+	case BLKTRACESTART:
+	case BLKTRACESTOP:
+	case BLKTRACETEARDOWN:
+	case BLKFLSBUF: /* Requires driver knowlege */
+	case BLKRRPART: /* No args */
+	default:
+		if (entering(tcp))
+			tprintf(", %#lx", arg);
+		break;
+
+	};
+	return 1;
+}
+#endif /* LINUX */
--- a/defs.h
+++ b/defs.h
@@ -550,6 +550,7 @@ extern int stream_ioctl(struct tcb *, in
 #ifdef LINUX
 extern int rtc_ioctl(struct tcb *, long, long);
 extern int scsi_ioctl(struct tcb *, long, long);
+extern int block_ioctl(struct tcb *, long, long);
 #endif
 
 extern int tv_nz(struct timeval *);
--- a/ioctl.c
+++ b/ioctl.c
@@ -152,6 +152,9 @@ long code, arg;
 #ifdef LINUX
 	case 'p':
 		return rtc_ioctl(tcp, code, arg);
+	case 0x03:
+	case 0x12:
+		return block_ioctl(tcp, code, arg);
 	case 0x22:
 		return scsi_ioctl(tcp, code, arg);
 #endif
--- a/linux/ioctlent.sh
+++ b/linux/ioctlent.sh
@@ -69,6 +69,9 @@ lookup_ioctls 56 linux/vt.h
 lookup_ioctls '7[12]' linux/videotext.h
 lookup_ioctls 89 $asm/sockios.h asm-generic/sockios.h linux/sockios.h
 lookup_ioctls 8B linux/wireless.h
+lookup_ioctls 03 linux/hdreg.h
+lookup_ioctls fd dm-ioctl.h
+lookup_ioctls 52 linux/rfkill.h
 
 if [ -e $dir/Kbuild ]; then
 	# kernel has exported user space headers, so query only them
-- 
Jeff Mahoney
SUSE Labs




More information about the Strace-devel mailing list