[PATCH] Decode struct ucred for getsockopt() with SO_PEERCRED.

Dmitry V. Levin ldv at altlinux.org
Sat Dec 4 00:06:16 UTC 2010


On Fri, Dec 03, 2010 at 02:59:29AM +0300, Dmitry V. Levin wrote:
> On Wed, Dec 01, 2010 at 02:42:37PM +0100, Arkadiusz Miśkiewicz wrote:
> > Decode struct ucred (pid, uid, gid) for getsockopt() with SO_PEERCRED.
> [...]
> > +					tprintf("{pid=%lu, uid=%lu, gid=%lu}, "
> > +						"[%d]",
> > +						ucred.pid,
> > +						ucred.uid,
> > +						ucred.gid,
> > +						len);
> 
> I think all these integers are rather signed than unsigned.
> There is a code in this file already that decodes struct ucred,
> it treats all these struct fields as signed integers.

I've applied my edition of the patch to address this issue.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20101204/0c9c47d0/attachment.bin>


More information about the Strace-devel mailing list