[t2] strace is broken on mips64 builds

[René Rebe]

Hi,

sorry for the delay, I overlooked that your mail included a patch and just noticed so today :-)

Committed revision 35996.

Greetings,
  René

On 17.03.2010, at 20:07, Jan Rovins wrote:

> All,
> 
> Got the following error when cross building strace for mips64,
> 
> The attached patch fixes this, the patch should go upstream too.
> 
> Jan
> 
> 
> 
> make[1]: Entering directory `/opt/T2/t2-trunk/src.strace.GW-Octeon-Pure64.20100317.141859.25474.ubuntu1/strace-4.5.19'
> mips64-octeon-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Ilinux/mips -I./linux/mips -Ilinux -I./linux   -Wall -g -O2 -MT strace.o -MD -MP -MF .deps/strace.Tpo -c -o strace.o strace.c
> mips64-octeon-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Ilinux/mips -I./linux/mips -Ilinux -I./linux   -Wall -g -O2 -MT syscall.o -MD -MP -MF .deps/syscall.Tpo -c -o syscall.o syscall.c
> mips64-octeon-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Ilinux/mips -I./linux/mips -Ilinux -I./linux   -Wall -g -O2 -MT count.o -MD -MP -MF .deps/count.Tpo -c -o count.o count.c
> mips64-octeon-linux-gnu-gcc -DHAVE_CONFIG_H -I. -Ilinux/mips -I./linux/mips -Ilinux -I./linux   -Wall -g -O2 -MT util.o -MD -MP -MF .deps/util.Tpo -c -o util.o util.c
> syscall.c: In function 'syscall_enter':
> syscall.c:2038: error: 'pid' undeclared (first use in this function)
> syscall.c:2038: error: (Each undeclared identifier is reported only once
> syscall.c:2038: error: for each function it appears in.)
> mv -f .deps/count.Tpo .deps/count.Po
> make[1]: *** [syscall.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> 
> diff -ur strace-4.5.19/syscall.c strace-4.5.19.fix/syscall.c
> --- strace-4.5.19/syscall.c	2009-10-12 15:54:21.000000000 -0400
> +++ strace-4.5.19.fix/syscall.c	2010-03-17 14:47:17.000000000 -0400
> @@ -2035,7 +2035,7 @@
> 		else
> 			nargs = tcp->u_nargs = MAX_ARGS;
> 
> -		if (ptrace (PTRACE_GETREGS, pid, NULL, (long) &regs) < 0)
> +		if (ptrace (PTRACE_GETREGS, tcp->pid, NULL, (long) &regs) < 0)
> 			return -1;
> 
> 		for(i = 0; i < nargs; i++) {
> ----------------------------------------------------------- 
> If you wish to unsubscribe from this mailing, send mail to
> lists at t2-project.org with a subject of: unsubscribe t2

-- 
  René Rebe, ExactCODE GmbH, Jaegerstr. 67, DE-10117 Berlin
  DE Legal: Amtsgericht Charlottenburg HRB 105123B, Tax-ID#: DE251602478
  Managing Directors: Susanne Klaus, René Rebe
  http://exactcode.com | http://t2-project.org | http://rene.rebe.name