[PATCH 1/2] Replace x86-64 paccept with accept4

Dmitry V. Levin ldv at altlinux.org
Tue Sep 1 18:49:38 UTC 2009


On Mon, Aug 17, 2009 at 05:33:25PM +0400, Dmitry V. Levin wrote:
> On Mon, Aug 17, 2009 at 03:08:07PM +0200, Paolo Bonzini wrote:
> > On 08/17/2009 03:06 PM, Dmitry V. Levin wrote:
> > > On Fri, Aug 14, 2009 at 12:34:05PM +0200, Paolo Bonzini wrote:
> > >> This patch changes the paccept syscall to accept4 for x86-64, since
> > >> the former was dropped in Linux kernel commit 2d4c8266.
> > >>
> > >> At the same time, it adds support for pretty-printing its arguments.
> > >
> > > The pretty printing part of the change is incomplete, it misses
> > > the case when 3rd arg is NULL.  Please consider a fix appended below.
> > > All the rest looks OK for me.
> > 
> > Right, my mistake.  Your version looks fine, thanks for fixing it on my 
> > behalf.
> 
> OK, I pushed fixed version of 1st part and 2nd part of the change to
> http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace;a=shortlog;h=pbonzini/accept4
> for further review.

I suppose that no further review for two weeks means OK for master branch.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20090901/2b5b621a/attachment.bin>


More information about the Strace-devel mailing list