[PATCH] Remove support for pre-C89

Dmitry V. Levin ldv at altlinux.org
Wed Oct 28 11:45:26 UTC 2009


On Tue, Oct 27, 2009 at 04:59:24PM +0100, Andreas Schwab wrote:
[..]
> * defs.h: Remove references to __STDC__ and P macros.
> * strace.c: Likewise.

I'm OK for removing this junk, but please be consistent and use the same
formatting style.  For example,

[...]
> @@ -158,15 +158,11 @@
>  #include <asm/ptrace.h>
>  #undef __KERNEL__
>  #endif
> -#ifdef __STDC__
>  #ifdef LINUX
>  extern long ptrace(int, int, char *, long);
>  #else /* !LINUX */
>  extern int ptrace(int, int, char *, int, ...);
>  #endif /* !LINUX */
> -#else /* !__STDC__ */
> -extern int ptrace();
> -#endif /* !__STDC__ */
>  #endif /* !LINUXSPARC */
>  #endif /* !SVR4 */

if we didn't put space after function names here,

[...]
> -extern int set_personality P((int personality));
> -extern const char *xlookup P((const struct xlat *, int));
> -extern struct tcb *alloc_tcb P((int, int));
> -extern struct tcb *pid2tcb P((int));
> -extern void droptcb P((struct tcb *));
> -extern void expand_tcbtab P((void));
> +extern int set_personality (int personality);
> +extern const char *xlookup (const struct xlat *, int);
> +extern struct tcb *alloc_tcb (int, int);
> +extern struct tcb *pid2tcb (int);
> +extern void droptcb (struct tcb *);
> +extern void expand_tcbtab (void);

why we put them here?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20091028/ec762a31/attachment.bin>


More information about the Strace-devel mailing list