Make strace correctly handle SIGTRAP produced by e.g.

Denys Vlasenko dvlasenk at redhat.com
Wed Nov 4 14:34:48 UTC 2009


On Tue, 2009-11-03 at 13:03 -0800, Roland McGrath wrote:
> > +	int sigtrap80;		/* What sig we consider to be ptrace stop */
> 
> This is a lousy name for the member.  "syscall_stopsig" or something fits.
> But I'm not really sure it is worthwhile to have per-tcb state for this at
> all.  If the ptrace features work they work on this kernel, period, that
> never varies across different tasks.  You can determine once what the
> ptrace feature support is, set every tracee the same way, and expect that
> behavior.

You are right. Further iterations of this code were using a single
global flag, and it was working just fine.

--
vda






More information about the Strace-devel mailing list