[PATCH] Add support for AVR32 architecture to strace

Mike Frysinger vapier at gentoo.org
Mon Feb 23 15:07:13 UTC 2009


On Monday 23 February 2009 02:07:08 Hans-Christian Egtvedt wrote:
> Please see the linked patch[0] which adds AVR32 architecture support to
> strace. Implemented by Håvard Skinnemoen (haavard.skinnemoen at atmel.com)
> and ported to latest CVS HEAD by me.
>
> The patch is based against current CVS HEAD. Tested on AP7000 with some
> random commands, and it seems to behave nice. I also tried going
> through the test/ directory, but they seem to be a bit outdated and a
> bit x86 specific AFAICT?
>
> If you have a preferred test suite, I can go through that as well.

you forgot to add avr32/ioctlent.h to the Makefile.am for dist

the 2nd hunk to defs.h is broken (look at the parenthesis)

is there a reason for normalizing the ioctlent.h so it doesnt resemble the 
output of ioctlsort anymore ?

do you really need your own ioctlent.sh ?  cant we keep this merged with the 
common linux one ?  otherwise, you've forgotten to add this to Makefile.am for 
dist too.

your syscallent.h seems to be lacking a lot of 5th arguments for standard 
functions.  i.e. sys_exit has SYS_exit, etc...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20090223/6ed07d7a/attachment.bin>


More information about the Strace-devel mailing list