[PATCH] strace: Fix up MIPS lookup_dcookie syscallent entry.

Ralf Baechle ralf at linux-mips.org
Wed Oct 31 12:56:21 UTC 2007


On Wed, Oct 31, 2007 at 05:21:49PM +0900, Paul Mundt wrote:

Hi Paul,

> While updating the SH syscallent I noticed that MIPS has an off-by-1 on
> its lookup_dcookie syscallent entry. arch/mips/kernel/scall32-o32.S also
> suggests that the number of arguments should be 4, rather than 3.

The first argument of cookie64 is a u64 so counts double in terms of
the number of arguments passing by the 32-bit syscall handler.

> Incidentally, all of the other architectures in strace have this set
> correctly, MIPS is simply the odd one out. As this just wraps to
> printargs it's a pretty minor issue. Ralf can yell if the 3 was
> intentional :-)

Not sure how this is to be handled in strace.

  Ralf




More information about the Strace-devel mailing list