[PATCH] strace: Fix up MIPS lookup_dcookie syscallent entry.

Paul Mundt lethal at linux-sh.org
Wed Oct 31 08:21:49 UTC 2007


While updating the SH syscallent I noticed that MIPS has an off-by-1 on
its lookup_dcookie syscallent entry. arch/mips/kernel/scall32-o32.S also
suggests that the number of arguments should be 4, rather than 3.

Incidentally, all of the other architectures in strace have this set
correctly, MIPS is simply the odd one out. As this just wraps to
printargs it's a pretty minor issue. Ralf can yell if the 3 was
intentional :-)

Against current CVS.

Signed-off-by: Paul Mundt <lethal at linux-sh.org>

---

 linux/mips/syscallent.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/mips/syscallent.h
===================================================================
RCS file: /cvsroot/strace/strace/linux/mips/syscallent.h,v
retrieving revision 1.28
diff -u -p -r1.28 syscallent.h
--- linux/mips/syscallent.h	2 Aug 2007 01:44:14 -0000	1.28
+++ linux/mips/syscallent.h	31 Oct 2007 08:13:22 -0000
@@ -4245,7 +4245,7 @@
 	{ 3,	0,	sys_io_submit,		"io_submit"	}, /* 4244 */
 	{ 3,	0,	sys_io_cancel,		"io_cancel"	}, /* 4245 */
 	{ 1,	TP,	sys_exit,		"exit_group"	}, /* 4246 */
-	{ 3,	0,	printargs,		"lookup_dcookie"}, /* 4247 */
+	{ 4,	0,	printargs,		"lookup_dcookie"}, /* 4247 */
 	{ 1,	0,	sys_epoll_create,	"epoll_create"	}, /* 4248 */
 	{ 4,	TD,	sys_epoll_ctl,		"epoll_ctl"	}, /* 4249 */
 	{ 3,	TD,	sys_epoll_wait,		"epoll_wait"	}, /* 4250 */




More information about the Strace-devel mailing list