[PATCH v6] Implement decoding of statx syscall

[Dmitry V. Levin]

On Sat, Mar 18, 2017 at 05:36:27PM +0300, Victor Krapivensky wrote:
> On Sat, Mar 18, 2017 at 10:44:09AM +0100, Eugene Syromyatnikov wrote:
[...]
> > Only one branch in regards of of stx.field.nsec value is covered in all
> > instances of this macro.
> 
> Yes. This seems to be a property of a filesystem. Anything I can do
> about that?

If the filesystem doesn't support non-zero nsec, I wouldn't bother.

> > Only branch with abbrev(tcp) == 0 is covered.
> 
> > ... and this one, but this is a common problem of all current *stat*
> > checks.
> 
> Should I add a test that checks that it abbreviates correctly?

If you ever in doubt whether to add a test or not, add a test. :)


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170319/be4200d3/attachment.bin>