[PATCH v2 1/2] xattr: use printstr_ex instead of print_quoted_string

JingPiao Chen chenjingpiao at gmail.com
Fri Dec 23 00:28:40 UTC 2016


>On Thu, Dec 22, 2016 at 04:10:51PM +0100, Gabriel Laskar wrote:
>> This fixes the display when using `-s` to limit the string size of the
>> values displayed by {get,set}xattr.
>>
>> * xattr.c (print_xattr_val): use printstr_ex instead of
>> print_quoted_string
>>
>> Reported-by: Марк Коренберг <socketpair at gmail.com>
>> Signed-off-by: Gabriel Laskar <gabriel at lse.epita.fr>
>On Thu, Dec 22, 2016 at 04:10:52PM +0100, Gabriel Laskar wrote:
>> * tests/xattr-strings.c: New file.
>> * tests/xattr-strings.test: New test.
>> * tests/.gitignore: Add xattr-string.
>> * tests/Makefile.am (check_PROGRAMS): Likewise.
>> (DECODER_TESTS): Add xattr-string.test.
>>
>> Signed-off-by: Gabriel Laskar <gabriel at lse.epita.fr>

>Applied, thanks!
>--
>ldv

Could I ask a question? All the string even in struct should comply with -s
option?
All the string should NUL terminate? Thanks.

--
JingPiao Chen

2016-12-23 7:41 GMT+08:00 Dmitry V. Levin <ldv at altlinux.org>:

> Hi,
>
> On Thu, Dec 22, 2016 at 04:10:51PM +0100, Gabriel Laskar wrote:
> > This fixes the display when using `-s` to limit the string size of the
> > values displayed by {get,set}xattr.
> >
> > * xattr.c (print_xattr_val): use printstr_ex instead of
> > print_quoted_string
> >
> > Reported-by: Марк Коренберг <socketpair at gmail.com>
> > Signed-off-by: Gabriel Laskar <gabriel at lse.epita.fr>
> On Thu, Dec 22, 2016 at 04:10:52PM +0100, Gabriel Laskar wrote:
> > * tests/xattr-strings.c: New file.
> > * tests/xattr-strings.test: New test.
> > * tests/.gitignore: Add xattr-string.
> > * tests/Makefile.am (check_PROGRAMS): Likewise.
> > (DECODER_TESTS): Add xattr-string.test.
> >
> > Signed-off-by: Gabriel Laskar <gabriel at lse.epita.fr>
>
> Applied, thanks!
>
>
> --
> ldv
>
> ------------------------------------------------------------
> ------------------
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today.http://sdm.link/intel
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20161223/e897e266/attachment.html>


More information about the Strace-devel mailing list