<p></p>
On Mon, Feb 07, 2022 at 11:00:43AM -0800, Sean Young via Strace-devel wrote:<br>
> Ready for review again.<br>
<br>
Looks great, thank you.<br>
<br>
> diff --git a/tests/ioctl_lirc.c b/tests/ioctl_lirc.c<br>
> new file mode 100644<br>
> index 0000000..df601e9<br>
> --- /dev/null<br>
> +++ b/tests/ioctl_lirc.c<br>
<br>
> +  value = 40000;<br>
> +  do_ioctl(LIRC_SET_REC_CARRIER_RANGE, &value);<br>
> +  printf("ioctl(-1, IPMICTL_SET_MAINTENANCE_MODE_CMD or LIRC_SET_REC_CARRIER_RANGE, [40000]) = %s\n",<br>
> +         errstr);<br>
<br>
In strace, string literals tend to be wrapped to be under 80 columns<br>
as well:<br>
<br>
        printf("ioctl(-1, IPMICTL_SET_MAINTENANCE_MODE_CMD"<br>
               " or LIRC_SET_REC_CARRIER_RANGE, [40000]) = %s\n",<br>
               errstr);<br>
<br>
> +  printf("ioctl(-1, LIRC_GET_FEATURES, [LIRC_CAN_SEND_PULSE|LIRC_CAN_SET_SEND_DUTY_CYCLE|LIRC_CAN_USE_WIDEBAND_RECEIVER|LIRC_CAN_GET_REC_RESOLUTION|0x8000000]) = %s\n",<br>
> +         errstr);<br>
<br>
        printf("ioctl(-1, LIRC_GET_FEATURES, [LIRC_CAN_SEND_PULSE"<br>
               "|LIRC_CAN_SET_SEND_DUTY_CYCLE|LIRC_CAN_USE_WIDEBAND_RECEIVER"<br>
               "|LIRC_CAN_GET_REC_RESOLUTION|0x8000000]) = %s\n",<br>
               errstr);<br>
<br>
> +  do_ioctl(LIRC_GET_FEATURES, (unsigned int*)0x40000);<br>
<br>
It is usually formatted as follows in strace:<br>
<br>
        do_ioctl(LIRC_GET_FEATURES, (unsigned int *) 0x40000);<br>
<br>
Since these are just minor formatting nits,<br>
<br>
Reviewed-by: Eugene Syromyatnikov ***@***.***><br>
<br>
> <br>
> -- <br>
> Reply to this email directly or view it on GitHub:<br>
> https://github.com/strace/strace/pull/208#issuecomment-1031810043<br>
> You are receiving this because you are subscribed to this thread.<br>
> <br>
> Message ID: ***@***.***><br>
<br>
> -- <br>
> Strace-devel mailing list<br>
> ***@***.***<br>
> https://lists.strace.io/mailman/listinfo/strace-devel<br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/208#issuecomment-1034484453">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTR4IYJ673ZIJSLBAX6TU2M6EJANCNFSM5M2WOHAQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AOVBTRZQTLMFNRMEDFB5Q2DU2M6EJA5CNFSM5M2WOHA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHWUPVZI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><strace/strace/pull/208/c1034484453</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/208#issuecomment-1034484453",
"url": "https://github.com/strace/strace/pull/208#issuecomment-1034484453",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>