<p></p>
<p><b>@ldv-alt</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/strace/strace/pull/208#discussion_r798572082">tests/Makefile.am</a>:</p>
<pre style='color:#555'>> @@ -200,6 +200,8 @@ check_PROGRAMS = $(PURE_EXECUTABLES) \
        ioctl_kd-success-s1024-Xabbrev \
        ioctl_kd-success-s1024-Xraw \
        ioctl_kd-success-s1024-Xverbose \
+       ioctl_lirc \
</pre>
<p dir="auto">ioctl_lirc is redundant in this list because it's listed in pure_executables.list;<br>
ioctl_lirc-success has to be kept here, see below.</p>

<hr>

<p>In <a href="https://github.com/strace/strace/pull/208#discussion_r798573364">tests/pure_executables.list</a>:</p>
<pre style='color:#555'>> @@ -209,6 +209,8 @@ ioctl_hdio-v-Xabbrev
 ioctl_hdio-v-Xraw
 ioctl_hdio-v-Xverbose
 ioctl_inotify
+ioctl_lirc
+ioctl_lirc-success
</pre>
<p dir="auto">*-success executables shouldn't be listed here because they are not pure enough.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/208#pullrequestreview-871852592">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTR5D2R5XKPHD6ENPXMTUZKAZFANCNFSM5M2WOHAQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AOVBTRZQ4YJMUMVJJUAVKZTUZKAZFA5CNFSM5M2WOHA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGP3WUMA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><strace/strace/pull/208/review/871852592</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/208#pullrequestreview-871852592",
"url": "https://github.com/strace/strace/pull/208#pullrequestreview-871852592",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>