<p></p>
<p><b>@ldv-alt</b> requested changes on this pull request.</p>

<p dir="auto">commit message: please change</p>
<pre><code>* src/printsiginfo.c: decode si_pkey field.
</code></pre>
<p dir="auto">to</p>
<pre><code>* src/printsiginfo.c (print_si_info) [HAVE_SIGINFO_T_SI_PKEY]: Decode
si_pkey field.
</code></pre><hr>

<p>In <a href="https://github.com/strace/strace/pull/210#discussion_r798696035">NEWS</a>:</p>
<pre style='color:#555'>> @@ -12,6 +12,7 @@ Noteworthy changes in release ?.?? (????-??-??)
   * Implemented decoding of PR_SET_VMA operation of prctl syscall.
   * Updated lists of FAN_*, IORING_*, IOSQE_*, KVM_*, MODULE_INIT_*, TCA_ACT_*,
     and *_MAGIC constants.
+  * Add decoding of si_pkey field in siginfo struct
</pre>
<p dir="auto">Please make sure each sentence ends with a dot.</p>
<p dir="auto">If you have a look at the NEWS file, you'll see that almost every<br>
"Improvements" section ends with "Updated lists of constants" line followed by<br>
"Updated lists of ioctl commands" line.<br>
Let's keep this tradition, please add your line before rather than after<br>
these lines.</p>

<hr>

<p>In <a href="https://github.com/strace/strace/pull/210#discussion_r798700698">src/printsiginfo.c</a>:</p>
<pre style='color:#555'>>              case SIGSEGV: case SIGBUS:
                        tprint_struct_next();
                        PRINT_FIELD_PTR(*sip, si_addr);
+#ifdef HAVE_SIGINFO_T_SI_PKEY
+                       if (sip->si_signo == SIGSEGV && sip->si_code == SEGV_PKUERR) {
+                               tprint_struct_next();
+                               PRINT_FIELD_D(*sip, si_pkey);
</pre>
<p dir="auto">Apparently, siginfo_t.si_pkey is not the only field that could be printed in case of SIGSEGV or SIGBUS,<br>
so I'd suggest to separate <code>case SIGSEG</code> and <code>case SIGBUS</code>, and use a <code>switch</code> on <code>sip->si_code</code> instead of an <code>if</code> statement.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/210#pullrequestreview-872028068">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTRZ6CW42I53TIP7K463UZKPUTANCNFSM5NL4DJ6Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AOVBTR6IJ6MHXAMHS3KKLPDUZKPUTA5CNFSM5NL4DJ62YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGP5BPJA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><strace/strace/pull/210/review/872028068</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/210#pullrequestreview-872028068",
"url": "https://github.com/strace/strace/pull/210#pullrequestreview-872028068",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>