<p></p>
<p><b>@ldv-alt</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/strace/strace/pull/208#discussion_r796532001">src/lirc.c</a>:</p>
<pre style='color:#555'>> +static const struct features {
+       int flag;
+       const char *name;
+} features[] = {
+       { LIRC_CAN_REC_SCANCODE, "LIRC_CAN_REC_SCANCODE" },
+       { LIRC_CAN_REC_MODE2, "LIRC_CAN_REC_MODE2" },
+       { LIRC_CAN_GET_REC_RESOLUTION, "LIRC_CAN_GET_REC_RESOLUTION" },
+       { LIRC_CAN_SEND_PULSE, "LIRC_CAN_SEND_PULSE" },
+       { LIRC_CAN_SET_TRANSMITTER_MASK, "LIRC_CAN_SET_TRANSMITTER_MASK" },
+       { LIRC_CAN_SET_SEND_CARRIER, "LIRC_CAN_SET_SEND_CARRIER" },
+       { LIRC_CAN_SET_SEND_DUTY_CYCLE, "LIRC_CAN_SET_SEND_DUTY_CYCLE" },
+       { LIRC_CAN_SET_REC_CARRIER, "LIRC_CAN_SET_REC_CARRIER" },
+       { LIRC_CAN_SET_REC_CARRIER_RANGE, "LIRC_CAN_SET_REC_CARRIER_RANGE" },
+       { LIRC_CAN_USE_WIDEBAND_RECEIVER, "LIRC_CAN_USE_WIDEBAND_RECEIVER" },
+       { LIRC_CAN_MEASURE_CARRIER, "LIRC_CAN_MEASURE_CARRIER" },
+       { LIRC_CAN_SET_REC_TIMEOUT, "LIRC_CAN_SET_REC_TIMEOUT" },
+};
</pre>
<p dir="auto">Given that linux/lirc.h is bundled, there is no need to test LIRC_* constants,<br>
so please add #unconditional to these xlat files.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/208#discussion_r796532001">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTR6GOZKZJYLB5SGTDSDUY7EQVANCNFSM5M2WOHAQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AOVBTR372YT5TWBAP4F7NZTUY7EQVA5CNFSM5M2WOHA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGPGHPHY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><strace/strace/pull/208/review/869037983</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/208#discussion_r796532001",
"url": "https://github.com/strace/strace/pull/208#discussion_r796532001",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>