<p></p>
<p><b>@ldv-alt</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/strace/strace/pull/208#discussion_r796535123">src/lirc.c</a>:</p>
<pre style='color:#555'>> +    switch (code) {
+       case LIRC_GET_FEATURES:
+               printflags(lirc_features, value, "LIRC_CAN_???");
+               break;
+       case LIRC_GET_SEND_MODE:
+       case LIRC_GET_REC_MODE:
+       case LIRC_SET_SEND_MODE:
+       case LIRC_SET_REC_MODE:
+               printxval(lirc_modes, value, "LIRC_MODE_???");
+               break;
+       default:
+               PRINT_VAL_D(value);
+               break;
+       }
</pre>
<p dir="auto">Since <code>value</code> is obtained from tracee's memory, its printing should be wrapped with</p>
<pre><code>tprint_indirect_begin();
...
tprint_indirect_end();
</code></pre>
<p dir="auto">See e.g. <code>decode_fs_ioc_flags</code> as an example.</p>
<p dir="auto">Also, <code>tprint_arg_next();</code> should precede any printing, this includes <code>umove_or_printaddr</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/208#pullrequestreview-869042529">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTR6SC6X6LIBF4OGQHN3UY7FBTANCNFSM5M2WOHAQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AOVBTR2QYG7BX6QMGJX54NTUY7FBTA5CNFSM5M2WOHA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGPGISYI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><strace/strace/pull/208/review/869042529</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/208#pullrequestreview-869042529",
"url": "https://github.com/strace/strace/pull/208#pullrequestreview-869042529",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>