<p></p>
<p>Yes, that's my point - just like unshare() with some options in pidns_test_init(), these ioctls are supposed to fail with EPERM in chroot.  The unshare() code path later checks and makes the test skip, but the ioctls fail and cause a test suite failure.</p>
<p>The pull request is adjusting the conditions so that the ioctl failure (when expected to fail), will make the test skipped instead of failing.</p>
<p>Perhaps a similar effect would be to move check_ns_ioctl() down so that it's not run at all when unshare() failed?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/strace/strace/pull/190#issuecomment-884079041">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AOVBTR42R2DZPLLJE5KLV2LTY2OIBANCNFSM5AWHHNAQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AOVBTRYMLZ63EYRPQIERISTTY2OIBA5CNFSM5AWHHNA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGSY7TQI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/strace/strace/pull/190#issuecomment-884079041",
"url": "https://github.com/strace/strace/pull/190#issuecomment-884079041",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>