<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello,</p>
<p>Please find the latest patch attached. PR's build is green.</p>
<p>Renaud.<br>
</p>
<div class="moz-cite-prefix">On 3/8/21 5:12 PM, Renaud Métrich
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:e3a7d138-b80e-c5b1-d489-c2fcced4191e@redhat.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<p>Hello,</p>
<p>Please check the newer code on github (<a
class="moz-txt-link-freetext"
href="https://github.com/strace/strace/pull/121"
moz-do-not-send="true">https://github.com/strace/strace/pull/121</a>),
I consider it's complete now.</p>
<p>The "<b>CI / coverage</b>" and "<strong class="text-emphasized
mr-2">CI / clang10-x86_64-dw (pull_request)</strong>" fail
because of a test not related to the change (<b>pidns-cache.test</b>
taking too much time).</p>
<p>Renaud.<br>
</p>
<div class="moz-cite-prefix">On 3/5/21 3:18 PM, Dmitry V. Levin
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20210305141819.GB14087@altlinux.org">
<pre class="moz-quote-pre" wrap="">On Fri, Mar 05, 2021 at 03:04:47PM +0100, Renaud Métrich wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Dear all,
I reworked the code and created some unit tests. (PR
<a class="moz-txt-link-freetext" href="https://github.com/strace/strace/pull/121" moz-do-not-send="true">https://github.com/strace/strace/pull/121</a>)
Unfortunately I'm not able to build correctly under the CI for several
reasons:
- code coverage breaks because the CI system has no SELinux labels,
hence the new code is not covered
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">Unfortunately, github actions don't enable some Linux features.
For example, they have no kvm support.
But I think you can collect the coverage locally, publish it somewhere,
and post the link here.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">- compilation with -m32 fails because there is no suitable selinux
library for 32bits apparently
e.g.
2021-03-05T13:17:54.4436301Z gcc-10 -Wall -Wempty-body -Wformat-security
-Wignored-qualifiers -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op
-Wmissing-parameter-type -Wnested-externs -Wold-style-declaration
-Wold-style-definition -Woverride-init -Wsign-compare -Wtype-limits
-Wwrite-strings -Werror -g -O2 -DMPERS_IS_m32 -m32 -o chmod--secontext
chmod--secontext.o -lselinux libtests.a
2021-03-05T13:17:54.4515828Z /usr/bin/ld: skipping incompatible
/usr/lib/x86_64-linux-gnu/libselinux.a when searching for -lselinux
2021-03-05T13:17:54.4517295Z /usr/bin/ld: cannot find -lselinux
2021-03-05T13:17:54.4518771Z /usr/bin/ld: skipping incompatible
/usr/lib/x86_64-linux-gnu/libselinux.so when searching for -lselinux
2021-03-05T13:17:54.4520200Z /usr/bin/ld: skipping incompatible
/usr/lib/x86_64-linux-gnu/libselinux.a when searching for -lselinux
2021-03-05T13:17:54.4521300Z /usr/bin/ld: cannot find -lselinux
2021-03-05T13:17:54.4522032Z collect2: error: ld returned 1 exit status
I have no idea what needs to be done to fix this. All I see is configure
enables selinux support because the 64bit lib is installed, but
apparently not the 32bit one.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">I suggest to implement something in m4/mpers.m4, similar to the way
AC_CHECK_SIZEOF is used there, so that selinux tests could be enabled per
mpers depending on the runtime availability.
</pre>
</blockquote>
</blockquote>
</body>
</html>