<div dir="ltr">I have a doubt:<div> There are three files file_ioctl.c, fs_x_ioctl.c and ioctl.c in the <a href="https://codecov.io/github/strace/strace">https://codecov.io/github/strace/strace</a> with their code coverages. Now I have to find the corresponding test files in the strace/tests/ and modify them to increase the code coverage right ?</div><div><br></div><div>please correct me if I am understanding wrong</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 26, 2017 at 8:36 PM, Eugene Syromyatnikov <span dir="ltr"><<a href="mailto:evgsyr@gmail.com" target="_blank">evgsyr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Dec 26, 2017 at 1:44 PM, Kommuru jai shankar reddy<br>
<<a href="mailto:kommurujaishankarreddy@gmail.com">kommurujaishankarreddy@gmail.com</a>> wrote:<br>
> Yes, I am interested in the micro project of adding tests to the test<br>
> suite. Could you please provide suggestions on getting started to this ?<br>
<br>
</span>Sure. I'd suggest starting with ioctl decoders that are not shown as<br>
covered in LCOV reports, these are rather low-hanging fruits. The next<br>
thing is rarely used features that have no tests or are poorly tested,<br>
like path tracing or stack printing. It would be also benefitical to<br>
add some tests that cover some not previously test-covered aspects of<br>
strace's behaviour, like daemonized tracer, but in order to do that<br>
properly, some understanding of the strace internal workings is<br>
needed, and it might be difficult at first.<br>
<br>
The tests themselves reside in tests directory. The make target of<br>
interest is "make check", and you might be interested in<br>
--enable-code-coverage configuration option.<br>
<br>
Note also that code that is not covered by tests is more likely to<br>
contain errors (especially if it is some obscure ioctl one rarely<br>
cares about), so do not hesitate to fix it in case discrepancies<br>
between kernel's and strace's interpretation of syscall arguments are<br>
observed.<br>
<div class="HOEnZb"><div class="h5"><br>
> On Mon, Dec 25, 2017 at 11:49 PM, Eugene Syromyatnikov <<a href="mailto:evgsyr@gmail.com">evgsyr@gmail.com</a>><br>
> wrote:<br>
>><br>
>> On Mon, Dec 25, 2017 at 5:06 PM, Kommuru jai shankar reddy<br>
>> <<a href="mailto:kommurujaishankarreddy@gmail.com">kommurujaishankarreddy@gmail.com</a>> wrote:<br>
>> > Hello,<br>
>> > I'm jaya shankar,. Computer science student of national institute<br>
>> > of<br>
>> > technology andhra pradesh, India<br>
>> > I have used strace for my mini project for tracing system calls of<br>
>> > malware<br>
>> > executables and it helped me a lot.<br>
>> > I want to contribute to the community and apply as student for GSOC<br>
>> > 2k18.<br>
>> > I'm having knowledge of kernel, C, git and basics of networking.<br>
>> > So, it would be great if any one suggest me some tasks for micro<br>
>> > projects<br>
>> > for gsoc, some bugs to fix for a beginner like me.<br>
>><br>
>> Thank you for showing interest in strace.<br>
>><br>
>> Please take a look at [1], [2], and [3] as starting points. As Chen<br>
>> JingPiao also noted recently [4], there is an ongoing effort to add<br>
>> netlink protocol decoding support to strace, which may be of interest,<br>
>> taking in account aforementioned background.<br>
>><br>
>> If you have any specific questions, don't hesitate to ask.<br>
>><br>
>> [1]<br>
>> <a href="https://sourceforge.net/p/strace/wiki/Guide%20for%20new%20contributors/" rel="noreferrer" target="_blank">https://sourceforge.net/p/<wbr>strace/wiki/Guide%20for%20new%<wbr>20contributors/</a><br>
>> [2] <a href="https://sourceforge.net/p/strace/wiki/Microprojects/" rel="noreferrer" target="_blank">https://sourceforge.net/p/<wbr>strace/wiki/Microprojects/</a><br>
>> [3] <a href="https://sourceforge.net/p/strace/wiki/FeatureRequests/" rel="noreferrer" target="_blank">https://sourceforge.net/p/<wbr>strace/wiki/FeatureRequests/</a><br>
>> [4] <a href="https://sourceforge.net/p/strace/mailman/message/36168713/" rel="noreferrer" target="_blank">https://sourceforge.net/p/<wbr>strace/mailman/message/<wbr>36168713/</a><br>
>><br>
>> --<br>
>> Eugene Syromyatnikov<br>
>> mailto:<a href="mailto:evgsyr@gmail.com">evgsyr@gmail.com</a><br>
>> xmpp:esyr@jabber.{ru|org}<br>
>><br>
>><br>
>> ------------------------------<wbr>------------------------------<wbr>------------------<br>
>> Check out the vibrant tech community on one of the world's most<br>
>> engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>
>> ______________________________<wbr>_________________<br>
>> Strace-devel mailing list<br>
>> <a href="mailto:Strace-devel@lists.sourceforge.net">Strace-devel@lists.sourceforge.net</a><br>
>> <a href="https://lists.sourceforge.net/lists/listinfo/strace-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/strace-devel</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Thanks<br>
><br>
> K.jaishankar reddy<br>
><br>
><br>
> ------------------------------<wbr>------------------------------<wbr>------------------<br>
> Check out the vibrant tech community on one of the world's most<br>
> engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>
> ______________________________<wbr>_________________<br>
> Strace-devel mailing list<br>
> <a href="mailto:Strace-devel@lists.sourceforge.net">Strace-devel@lists.sourceforge.net</a><br>
> <a href="https://lists.sourceforge.net/lists/listinfo/strace-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/strace-devel</a><br>
><br>
<br>
<br>
<br>
--<br>
Eugene Syromyatnikov<br>
mailto:<a href="mailto:evgsyr@gmail.com">evgsyr@gmail.com</a><br>
xmpp:esyr@jabber.{ru|org}<br>
<br>
------------------------------<wbr>------------------------------<wbr>------------------<br>
Check out the vibrant tech community on one of the world's most<br>
engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>
______________________________<wbr>_________________<br>
Strace-devel mailing list<br>
<a href="mailto:Strace-devel@lists.sourceforge.net">Strace-devel@lists.sourceforge.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/strace-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/strace-devel</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Thanks<br><br>K.jaishankar reddy<br><br></div>
</div>