<div dir="ltr"><div class="gmail_extra"><div class="gmail_extra">On Sat, Jun 17, 2017 at 04:06:50PM +0300, Dmitry V. Levin wrote:</div><div class="gmail_extra">> On Sat, Jun 17, 2017 at 08:55:29PM +0800, JingPiao Chen wrote:</div><div class="gmail_extra">> > On Sat, Jun 17, 2017 at 03:27:30PM +0300, Dmitry V. Levin wrote:</div><div class="gmail_extra">> > > On Sat, Jun 17, 2017 at 07:18:29PM +0800, JingPiao Chen wrote:</div><div class="gmail_extra">> > > > On Sat, Jun 17, 2017 at 12:35:15AM +0300, Dmitry V. Levin wrote:</div><div class="gmail_extra">> > > > > On Sat, May 20, 2017 at 07:42:19PM +0800, JingPiao Chen wrote:</div><div class="gmail_extra">[...]</div><div class="gmail_extra">> > > This is better, but yet you'd create two different parsers</div><div class="gmail_extra">> > > for NLA_U64 and NLA_MSECS which are identical.</div><div class="gmail_extra">> > > </div><div class="gmail_extra">> > > Would it be better if we introduced functions for parsing each nla type?</div><div class="gmail_extra">> > </div><div class="gmail_extra">> > I prefer to introduced functions for parsing each nla type,</div><div class="gmail_extra">> > Like this:</div><div class="gmail_extra">> > </div><div class="gmail_extra">> > typedef (*nla_decoder_t)(struct tcb *,</div><div class="gmail_extra">> </div><div class="gmail_extra">> Do not forget about the return code type.</div><div class="gmail_extra">> </div><div class="gmail_extra">> > <span class="gmail-Apple-tab-span" style="white-space:pre">                     </span> kernel_ulong_t addr,</div><div class="gmail_extra">> > <span class="gmail-Apple-tab-span" style="white-space:pre">                  </span> kernel_ulong_t len,</div><div class="gmail_extra">> > <span class="gmail-Apple-tab-span" style="white-space:pre">                   </span> void *opaque_data);</div><div class="gmail_extra">> > static const nla_decoder_t unix_nla_decoders[] = {</div><div class="gmail_extra">> > <span class="gmail-Apple-tab-span" style="white-space:pre">  </span>[UNIX_DIAG_PEER] = decode_nla_u32,</div><div class="gmail_extra">> > <span class="gmail-Apple-tab-span" style="white-space:pre">     </span>[UNIX_DIAG_ICONS] = decode_unix_diag_icons</div><div class="gmail_extra">> > };</div><div class="gmail_extra">> </div><div class="gmail_extra">> Go ahead then. :)</div><div class="gmail_extra"><br></div><div class="gmail_extra">Ok, I will send to mailing list after I fixed. Thank you.</div><div class="gmail_extra"><br></div><div class="gmail_extra">--</div><div class="gmail_extra">JingPiao Chen</div></div></div>