<div dir="ltr"><div>On Fri, Jun 16, 2017 at 04:07:10AM +0300, Dmitry V. Levin wrote:</div><div>> On Thu, Jun 15, 2017 at 12:30:54PM +0800, JingPiao Chen wrote:</div><div>> > * tests/netlink_sock_diag.c: Include <linux/smc_diag.h>.</div><div>> > (SMC_ACTIVE): New macro.</div><div>> > (test_smc_diag_req, test_smc_diag_msg): New functions.</div><div>> > (main): Use them.</div><div>> </div><div>> Thanks, applied with a few changes.</div><div><br></div><div>Thank you for your detailed reply.</div><div>I have rebased my code[1]. Please have a look, and give me some feedback,</div><div>Do I need to redesign netlink attribute data decode[2]? Like:</div><div><br></div><div>typedef (*nla_decoder_t)(struct tcb *,</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">                       </span> kernel_ulong_t addr,</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">                  </span> kernel_ulong_t len,</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">                   </span> void *opaque_data);</div><div>static const nla_decoder_t unix_nla_decoders[] = {</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">  </span>[UNIX_DIAG_PEER] = decode_nla_u32,</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">     </span>[UNIX_DIAG_ICONS] = decode_unix_diag_icons</div><div>};</div><div>decode_nlattr(tcp, addr, len, sizeof(msg), unix_diag_attrs,             </div><div><span class="gmail-Apple-tab-span" style="white-space:pre">      </span>      "UNIX_DIAG_???", ARRAY_SIZE(unix_nla_decoders),</div><div><span class="gmail-Apple-tab-span" style="white-space:pre">     </span>      unix_nla_decoders, NULL);</div><div>Thank you.</div><div><br></div><div>[1]<a href="https://github.com/ppiao/strace">https://github.com/ppiao/strace</a></div><div>[2]<a href="https://github.com/ppiao/strace/commit/47ee4e43658b3db9c57bcd3857c51df0585f526e">https://github.com/ppiao/strace/commit/47ee4e43658b3db9c57bcd3857c51df0585f526e</a></div><div><br></div><div>--</div><div>JingPiao Chen</div></div>