<div dir="ltr">well so i have changed clock.tests's comment style.Below is the patch.Also i have changed the version to what you have set in subject.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 19, 2017 at 7:37 AM, Rishi Bhatt <span dir="ltr"><<a href="mailto:bhatt.rishi062@gmail.com" target="_blank">bhatt.rishi062@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sun, Mar 19, 2017 at 6:34 AM, Dmitry V. Levin <span dir="ltr"><<a href="mailto:ldv@altlinux.org" target="_blank">ldv@altlinux.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Sat, Mar 18, 2017 at 07:35:49PM +0530, Rishi Bhatt wrote:<br>
> Hey if i am taking rt_sigretrun,nanosleep as negative testcases i am<br>
> getting sigusr and sigalarm respectively, i should not get them right?<br>
> Also sched.test is also failing for them. Well i have included fstat and<br>
> open as negatives.<br>
><br>
> The way these test is made which expect the last output to be<br>
> '+++ exited with 0 +++' -> this is causing the test failure for some tests<br>
> from the suite.Well should i work to make this test better or there is<br>
> something else which i am not taking into consideration?<br>
<br>
</span>Some test programs cannot be easily reused for this %clock test because<br>
they fork, raise/catch signals, etc.<br>
<br>
But hundreds of test programs are well fit for this test: their strace<br>
output consists of syscalls and the final "exited" line only.<br>
<br>
> From ba969213641b0c80defc908a6921ba<wbr>4b498de0a7 Mon Sep 17 00:00:00 2001<br>
> From: Rishi Bhatt <<a href="mailto:bhatt.rishi062@gmail.com" target="_blank">bhatt.rishi062@gmail.com</a>><br>
> Date: Thu, 16 Mar 2017 14:41:55 +0530<br>
> Subject: [PATCH v4] Implemented -e trace=%clock option<br>
<br>
v4? Again?<br></blockquote><div><br></div></span><div>So which one is it? <br></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
[...]<br>
> --- a/sysent.h<br>
> +++ b/sysent.h<br>
> @@ -22,5 +22,6 @@ typedef struct sysent {<br>
<span>> #define TRACE_INDIRECT_SUBCALL 02000 /* Syscall is an indirect socket/ipc subcall. */<br>
> #define COMPAT_SYSCALL_TYPES 04000 /* A compat syscall that uses compat types. */<br>
> #define TRACE_SCHED 010000 /* Trace scheduler-related syscalls. */<br>
</span><span>> +#define TRACE_CLOCK 020000 /*Trace clock-related syscalls. */<br>
<br>
</span>Unfortunately, I have to repeat myself:<br>
<div class="m_8932702500831789225HOEnZb"><div class="m_8932702500831789225h5"><br>
"Please follow the style used in the file you are patching,<br>
in particular, the style of comments."<br></div></div></blockquote><div><br></div></span><div>In clock.test,and any other file? <br></div><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_8932702500831789225HOEnZb"><div class="m_8932702500831789225h5">
<br>
<br>
</div></div><span class="m_8932702500831789225HOEnZb"><font color="#888888">--<br>
ldv<br>
</font></span><br>------------------------------<wbr>------------------------------<wbr>------------------<br>
Check out the vibrant tech community on one of the world's most<br>
engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br>______________________________<wbr>_________________<br>
Strace-devel mailing list<br>
<a href="mailto:Strace-devel@lists.sourceforge.net" target="_blank">Strace-devel@lists.sourceforge<wbr>.net</a><br>
<a href="https://lists.sourceforge.net/lists/listinfo/strace-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/strace-devel</a><br>
<br></blockquote></span></div><br></div></div>
</blockquote></div><br></div>